Skip to content

SNS: Fixing tag format in AWS Config resource items - #10136

Open
rondodev wants to merge 2 commits into
getmoto:masterfrom
rondodev:fix/sns_tags
Open

SNS: Fixing tag format in AWS Config resource items#10136
rondodev wants to merge 2 commits into
getmoto:masterfrom
rondodev:fix/sns_tags

Conversation

@rondodev

Copy link
Copy Markdown
Contributor

Tags on SNS topics came back as null when read through moto's AWS Config integration (tested with Cloud Custodian policies with source: config).

The config item from get_config_resource didn't match real AWS Config output:

  • missing the top-level tags map
  • supplementaryConfiguration.Tags used uppercase Key/Value instead of lowercase key/value

@rondodev
rondodev marked this pull request as ready for review July 28, 2026 12:26
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.24%. Comparing base (fd49aae) to head (7e7111f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10136   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files        1326     1326           
  Lines      121003   121003           
=======================================
+ Hits       112831   112832    +1     
+ Misses       8172     8171    -1     
Flag Coverage Δ
servertests 27.95% <ø> (ø)
unittests 93.22% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant